Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validator should check for mandatory swagger or openapi field #137

Merged
merged 4 commits into from
Feb 17, 2020

Conversation

SaltedCaramelCoffee
Copy link
Contributor

This feature is in done in response to #126

Currently, our validator does not check the existence of mandatory field openapi in openapi3 api definitions, or swagger field in swagger2 api definitions.

This PR allows validator to check for the fields, as well as validate the field type and value.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #137 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   92.96%   92.99%   +0.03%     
==========================================
  Files          58       59       +1     
  Lines        2146     2156      +10     
==========================================
+ Hits         1995     2005      +10     
  Misses        151      151
Impacted Files Coverage Δ
src/cli-validator/utils/modified-commander.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8060a...44ce428. Read the comment docs.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@SaltedCaramelCoffee SaltedCaramelCoffee merged commit b4275d3 into master Feb 17, 2020
@SaltedCaramelCoffee SaltedCaramelCoffee deleted the mandatory-swagger-openapi-field branch February 17, 2020 16:33
dpopp07 pushed a commit that referenced this pull request Feb 17, 2020
# [0.20.0](v0.19.3...v0.20.0) (2020-02-17)

### Features

* validator should check for mandatory swagger or openapi field ([#137](#137)) ([b4275d3](b4275d3))
@dpopp07
Copy link
Member

dpopp07 commented Feb 17, 2020

🎉 This PR is included in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants